refactor: use shared make_headers instead of inline GitHub header dicts#413
Closed
jamesrayammons wants to merge 2 commits intoentrius:testfrom
Closed
refactor: use shared make_headers instead of inline GitHub header dicts#413jamesrayammons wants to merge 2 commits intoentrius:testfrom
jamesrayammons wants to merge 2 commits intoentrius:testfrom
Conversation
Replace inline {'Authorization': f'token {token}', 'Accept': ...} header
dicts with the existing make_headers() utility from utils/github_api_tools.
Files changed:
- cli/miner_commands/post.py
- validator/issue_discovery/repo_scan.py
Author
|
@anderdc @LandynDev Could you please this PR? |
Collaborator
|
Closing this one out. The change only touches 2 callsites and the payoff isn't really worth the merge overhead. If we do a broader consolidation of inline GitHub headers later we can revisit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace inline
{'Authorization': f'token {token}', 'Accept': ...}header dicts with the existingmake_headers()utility fromutils/github_api_tools.py.Related Issues
N/A (code cleanup)
Type of Change
Testing
No behavior change —
make_headers()returns the identical dict that was previously inline.Checklist